Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable xdebug only when starting server with --xdebug #609

Merged
merged 3 commits into from
Aug 21, 2023
Merged

Conversation

joehoyle
Copy link
Member

@joehoyle joehoyle commented Aug 2, 2023

We're going to disabled the xdebug extension in production in https://github.com/humanmade/docker-wordpress-php/pull/190

This re-enables it. The extension now is also only enabled when starting the server with --xdebug.

We're going to disabled the xdebug extension in production in humanmade/docker-wordpress-php#190

This re-enables it. It would be better to also only do this on `--xdebug`, so will follow up with that actually.
@joehoyle joehoyle changed the title Enable xdebug Enable xdebug onlny when starting server with --zdebug Aug 21, 2023
@joehoyle joehoyle requested a review from a team August 21, 2023 07:13
@joehoyle joehoyle marked this pull request as ready for review August 21, 2023 07:13
@joehoyle joehoyle changed the title Enable xdebug onlny when starting server with --zdebug Enable xdebug onlny when starting server with --xdebug Aug 21, 2023
@joehoyle joehoyle changed the title Enable xdebug onlny when starting server with --xdebug Enable xdebug only when starting server with --xdebug Aug 21, 2023
@hm-backport
Copy link

hm-backport bot commented Aug 21, 2023

The backport to v13-branch failed:

Commits ["457a2de6b1f809ab1c0fa619efbd1a5b9ee5d68f","f74b16892737c7af405cec033582a900ea33162b","8d7dbd0fb57e2031ed4daf8b8d45c796fa6c8d5a"] could not be cherry-picked on top of v13-branch

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub.
git fetch
# Create new working tree.
git worktree add .worktrees/backport v13-branch
# Navigate to the new directory.
cd .worktrees/backport
# Cherry-pick all the commits of this pull request and resolve the likely conflicts.
git cherry-pick 457a2de6b1f809ab1c0fa619efbd1a5b9ee5d68f f74b16892737c7af405cec033582a900ea33162b 8d7dbd0fb57e2031ed4daf8b8d45c796fa6c8d5a
# Create a new branch with these backported commits.
git checkout -b backport-609-to-v13-branch
# Push it to GitHub.
git push --set-upstream origin backport-609-to-v13-branch
# Go back to the original working tree.
cd ../..
# Delete the working tree.
git worktree remove .worktrees/backport

Then, create a pull request where the base branch is v13-branch and the compare/head branch is backport-609-to-v13-branch.

@hm-backport
Copy link

hm-backport bot commented Aug 21, 2023

The backport to v14-branch failed:

Commits ["457a2de6b1f809ab1c0fa619efbd1a5b9ee5d68f","f74b16892737c7af405cec033582a900ea33162b","8d7dbd0fb57e2031ed4daf8b8d45c796fa6c8d5a"] could not be cherry-picked on top of v14-branch

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub.
git fetch
# Create new working tree.
git worktree add .worktrees/backport v14-branch
# Navigate to the new directory.
cd .worktrees/backport
# Cherry-pick all the commits of this pull request and resolve the likely conflicts.
git cherry-pick 457a2de6b1f809ab1c0fa619efbd1a5b9ee5d68f f74b16892737c7af405cec033582a900ea33162b 8d7dbd0fb57e2031ed4daf8b8d45c796fa6c8d5a
# Create a new branch with these backported commits.
git checkout -b backport-609-to-v14-branch
# Push it to GitHub.
git push --set-upstream origin backport-609-to-v14-branch
# Go back to the original working tree.
cd ../..
# Delete the working tree.
git worktree remove .worktrees/backport

Then, create a pull request where the base branch is v14-branch and the compare/head branch is backport-609-to-v14-branch.

@hm-backport
Copy link

hm-backport bot commented Aug 21, 2023

The backport to v15-branch failed:

Commits ["457a2de6b1f809ab1c0fa619efbd1a5b9ee5d68f","f74b16892737c7af405cec033582a900ea33162b","8d7dbd0fb57e2031ed4daf8b8d45c796fa6c8d5a"] could not be cherry-picked on top of v15-branch

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub.
git fetch
# Create new working tree.
git worktree add .worktrees/backport v15-branch
# Navigate to the new directory.
cd .worktrees/backport
# Cherry-pick all the commits of this pull request and resolve the likely conflicts.
git cherry-pick 457a2de6b1f809ab1c0fa619efbd1a5b9ee5d68f f74b16892737c7af405cec033582a900ea33162b 8d7dbd0fb57e2031ed4daf8b8d45c796fa6c8d5a
# Create a new branch with these backported commits.
git checkout -b backport-609-to-v15-branch
# Push it to GitHub.
git push --set-upstream origin backport-609-to-v15-branch
# Go back to the original working tree.
cd ../..
# Delete the working tree.
git worktree remove .worktrees/backport

Then, create a pull request where the base branch is v15-branch and the compare/head branch is backport-609-to-v15-branch.

@hm-backport
Copy link

hm-backport bot commented Aug 21, 2023

The backport to v16-branch failed:

Commits ["457a2de6b1f809ab1c0fa619efbd1a5b9ee5d68f","f74b16892737c7af405cec033582a900ea33162b","8d7dbd0fb57e2031ed4daf8b8d45c796fa6c8d5a"] could not be cherry-picked on top of v16-branch

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub.
git fetch
# Create new working tree.
git worktree add .worktrees/backport v16-branch
# Navigate to the new directory.
cd .worktrees/backport
# Cherry-pick all the commits of this pull request and resolve the likely conflicts.
git cherry-pick 457a2de6b1f809ab1c0fa619efbd1a5b9ee5d68f f74b16892737c7af405cec033582a900ea33162b 8d7dbd0fb57e2031ed4daf8b8d45c796fa6c8d5a
# Create a new branch with these backported commits.
git checkout -b backport-609-to-v16-branch
# Push it to GitHub.
git push --set-upstream origin backport-609-to-v16-branch
# Go back to the original working tree.
cd ../..
# Delete the working tree.
git worktree remove .worktrees/backport

Then, create a pull request where the base branch is v16-branch and the compare/head branch is backport-609-to-v16-branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants