Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually load altis/core in Composer plugin #502

Merged
merged 2 commits into from
Jul 19, 2022

Conversation

rmccue
Copy link
Member

@rmccue rmccue commented Jul 16, 2022

Fixes #501.

Using Composer 2.1.9 locally, confirmed this fixes the command for me.

@rmccue rmccue requested review from roborourke and kovshenin July 16, 2022 12:26
Copy link
Contributor

@roborourke roborourke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add it as a peer dep suggestion or requirement with version * too?

inc/composer/class-plugin.php Outdated Show resolved Hide resolved
@kovshenin
Copy link
Contributor

Should we add it as a peer dep suggestion or requirement with version * too?

If this package is not intended to be used on its own, I don't think we need to add the requirement here, or to any other Altis module that uses Altis\get_config(). We should also remove the "Installation without Altis" section from the readme if that's the case, then for #497 we can suggest trying to composer require --dev altis/core with no guarantee that it will continue working in the future.

@rmccue
Copy link
Member Author

rmccue commented Jul 18, 2022

If it's not onerous for us, we can add the dep, but otherwise I'd say whatever is least painful for us.

Co-authored-by: Konstantin Kovshenin <[email protected]>
@rmccue rmccue requested a review from kovshenin July 18, 2022 10:24
@kovshenin kovshenin merged commit d717b6b into master Jul 19, 2022
@kovshenin kovshenin deleted the force-manual-altis-core-load branch July 19, 2022 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Call to undefined function Altis\get_config()
3 participants