Support XDebug on Linux #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #184 This changes from manually setting the XDEBUG_SESSION cookie and relying remote enabling in favour of setting the XDEBUG_CONFIG environment variable. This will ensure that the debugger connects every time and will handle setting the cookie itself. This also means XDebug can be used to debug CLI commands. Given that local server has 2 separate modes, with & without xdebug having it always be on in xdebug mode is worth the performance hit as developers can easily switch back.
![hm-linter[bot]](https://avatars.githubusercontent.com/in/5455?s=60&v=4){kind=small}
I forgot that although the container is running PHP 7.2 the host machine where `PHP_OS_FAMILY` is in use might not be.
kadamwhite
approved these changes
Jul 15, 2020
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub.
git fetch
# Create new working tree.
git worktree add .worktrees/backport v3-branch
# Navigate to the new directory.
cd .worktrees/backport
# Cherry-pick all the commits of this pull request and resolve the likely conflicts.
git cherry-pick 37a1a28565b7a028dc4bf7d895c3bd5f2704c47b 3ac5c5fe8129699599bfc140336140a54c06bdab 007fa5b4512b52a1d78e09af170bfb7b24fda9c0 5afaa32ecaa09b4f4d7d3a89c9c8cbaceeb52580 fed9436329628728a9a3e51a561f0e21f7892242 699c9d69d0ff61349d4fd2db202f8b23702e926b a36668d2209bc590ea88fbf0be06f2c2de11c390
# Create a new branch with these backported commits.
git checkout -b backport-185-to-v3-branch
# Push it to GitHub.
git push --set-upstream origin backport-185-to-v3-branch
# Go back to the original working tree.
cd ../..
# Delete the working tree.
git worktree remove .worktrees/backportThen, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub.
git fetch
# Create new working tree.
git worktree add .worktrees/backport v3-branch
# Navigate to the new directory.
cd .worktrees/backport
# Cherry-pick all the commits of this pull request and resolve the likely conflicts.
git cherry-pick 37a1a28565b7a028dc4bf7d895c3bd5f2704c47b 3ac5c5fe8129699599bfc140336140a54c06bdab 007fa5b4512b52a1d78e09af170bfb7b24fda9c0 5afaa32ecaa09b4f4d7d3a89c9c8cbaceeb52580 fed9436329628728a9a3e51a561f0e21f7892242 699c9d69d0ff61349d4fd2db202f8b23702e926b a36668d2209bc590ea88fbf0be06f2c2de11c390
# Create a new branch with these backported commits.
git checkout -b backport-185-to-v3-branch
# Push it to GitHub.
git push --set-upstream origin backport-185-to-v3-branch
# Go back to the original working tree.
cd ../..
# Delete the working tree.
git worktree remove .worktrees/backportThen, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub.
git fetch
# Create new working tree.
git worktree add .worktrees/backport v4-branch
# Navigate to the new directory.
cd .worktrees/backport
# Cherry-pick all the commits of this pull request and resolve the likely conflicts.
git cherry-pick 37a1a28565b7a028dc4bf7d895c3bd5f2704c47b 3ac5c5fe8129699599bfc140336140a54c06bdab 007fa5b4512b52a1d78e09af170bfb7b24fda9c0 5afaa32ecaa09b4f4d7d3a89c9c8cbaceeb52580 fed9436329628728a9a3e51a561f0e21f7892242 699c9d69d0ff61349d4fd2db202f8b23702e926b a36668d2209bc590ea88fbf0be06f2c2de11c390
# Create a new branch with these backported commits.
git checkout -b backport-185-to-v4-branch
# Push it to GitHub.
git push --set-upstream origin backport-185-to-v4-branch
# Go back to the original working tree.
cd ../..
# Delete the working tree.
git worktree remove .worktrees/backportThen, create a pull request where the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #184
This update uses the
XDEBUG_CONFIGenvironment variable to set two things:idekey: this enables xdebug for every run of PHP and handles setting the cookie if not already presentremote_host:host.docker.internalis a special value for Windows and Mac only, Linux distros can use the static IP 172.17.0.1 to communicate with the host machineBecause xdebug is switched on or off by switching container I think its ok to run every time. This has the added benefit of being able to use xdebug with CLI commands.