Add ES package support #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overrides the stored package IDs locally. Changes the S3 sync to overwrite to enable updates from S3 when package files are updated. Mounts the `content/uploads/search` directory into the ES config directory so that files can be referenced in a consistent way with how they are referenced on AWS
The Minio watch command can sometimes fail if it has been running too long.
![hm-linter[bot]](https://avatars.githubusercontent.com/in/5455?s=60&v=4){kind=small}
joehoyle
approved these changes
Jul 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to user dictionary support humanmade/altis-enhanced-search#76
This allows local server to interact with the package functionality in the search module.
I couldn't find a better solution unfortunately due to the limitations of not being to write any files to the PHP container, even if it's a volume. I had to write files to S3, then rely on the S3 sync to host service and mount that directory on to the Elasticsearch container.
The
docker-compose.ymlupdates to the S3 sync and its restart policy should help keep this as robust as it can be in the current form.