Turn on error display for local server

[pdewouters]

[hm-linter]

Linting failed (1 error).

1 notice occurred in your codebase, but none on files/lines included in this PR.

[joehoyle]

It looks like this will mean display_errors will no longer be on for non-cli (as that line of code got removed?)

Could we just set this for cli & fpm by setting the value in https://github.com/humanmade/altis-local-server/blob/master/docker/php.ini?

[pdewouters]

@joehoyle are the acceptance criteria here outdated then? #123

[joehoyle]

Ah thanks for linking @pdewouters -- could you link the original issues in subsequent PRs too to give extra context.

It looks like that acceptance criteria actually came from @roborourke! He edited my comment :D

It does actually looked like we want to rmove display_errors from the web context per @rmccue 's response:

FWIW, it's already turned on in the local-server bootstrap file, but we should actually remove this so that errors aren't displayed in a HTML context:

I guess that's fine, though I'm not entirely sure why we don't want to show errors in the web context! In which case anyway, judging by the notes on #123 then this PR is good to go.

[rmccue]

I think this should be set in the .ini rather than in wp-config FWIW

[joehoyle]

@rmccue that will affect both web and cli though, which you comment specifically recommends against I think?

[rmccue]

Yeah; I think local-server might need to distinguish the two SAPIs and separate the configuration, the same way that e.g. Ubuntu PHP does.