Fix memory usage in ES #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was mistakenly ignoring the first block, which meant ES was using its default of 1GB of memory regardless of the setting for 512MB.
![hm-linter[bot]](https://avatars.githubusercontent.com/in/5455?s=60&v=4){kind=small}
kadamwhite
approved these changes
Jun 11, 2020
There was a problem hiding this comment.
This does indeed seem to fix things for me! Excellent work, @rmccue, this is fantastic news.
Is there any sort of YAML linter that would detect duplicate keys, I wonder?
roborourke
approved these changes
Jun 11, 2020
|
Now available in version 3.0.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #115.
#44 added a new environment option, which overrode the existing one where we set the memory limit for Java. This meant that Java was trying to use more memory than the container was actually allocated, getting it killed by the OOM killer.
Additionally, because the config sets network.host, ES switches into production mode. Notably, this turns the bootstrap checks from warnings into exceptions, which means that ES doesn't launch due to the low
vm.max_map_countvalue. To switch it back into development mode, we need to change the discovery type back to single node (which is another env var we can set here).All up, this should fix the ES memory problems and other related startup problems; it should also now not be necessary to increase Docker's memory limit.