Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only set the X-Ray daemon address if it isn't already defined #156

Merged
merged 1 commit into from
May 18, 2020
Merged

Only set the X-Ray daemon address if it isn't already defined #156

merged 1 commit into from
May 18, 2020

Conversation

joehoyle
Copy link
Member

This avoids a notice in some cases.

@joehoyle joehoyle requested review from rmccue and roborourke May 14, 2020 07:56
@roborourke roborourke merged commit 9377e62 into master May 18, 2020
@roborourke roborourke deleted the fix-notice-xray-daemon branch May 18, 2020 17:47
@roborourke
Copy link
Contributor

Does this need backporting?

@joehoyle
Copy link
Member Author

Nah i think it's fine, just a small enhacement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hm-linter hm-linter[bot] hm-linter[bot] approved these changes

@rmccue rmccue rmccue approved these changes

@roborourke roborourke Awaiting requested review from roborourke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joehoyle @roborourke @rmccue