Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore PHPCS errors in composer command #155

Merged
merged 1 commit into from
May 11, 2020
Merged

Conversation

roborourke
Copy link
Contributor

Calls to functions like file_get_contents() etc... are being flagged as errors however in the composer command we are outside the scope of WordPress so there's no problem using them.

Calls to functions like `file_get_contents()` etc... are being flagged as errors however in the composer command we are outside the scope of WordPress so there's no problem using them.
@roborourke roborourke requested review from joehoyle and rmccue May 8, 2020 13:09
Copy link
Member

@joehoyle joehoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really feel like we should remove these from phpcs!

@joehoyle joehoyle merged commit c6dd6d6 into master May 11, 2020
@joehoyle joehoyle deleted the ignore-hmlinter-errors branch May 11, 2020 07:56
@rmccue
Copy link
Member

rmccue commented May 11, 2020

I did remove them in the HM-Required ruleset, and didn't add to HM, so they'll go away soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants