Add support for Signed Urls in Tachyon #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we have mix between using path-type and subdomain-style S3 bucket urls in Local Server. Because Tachyon, and the WordPress application use different URLs patterns, it means the Signed URLs generated between them are not compatible (the url path is part of the signature, so the path has to be the same in both). We've sinse added support for loop-back requests to the S3 container on the proxy network, so we can now use the "s3-$project.altis.dev" hostname from the Tahcyon container, matching the hostname we use from the WordPress applicatio container. It also means we don't need to change the behaviour of the S3 SDK to special-case local development.
![hm-linter[bot]](https://avatars.githubusercontent.com/in/5455?s=60&v=4){kind=small}
rmccue
approved these changes
Apr 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we have mix between using path-type and subdomain-style S3 bucket urls in Local Server. Because Tachyon, and the WordPress application use different URLs patterns, it means the Signed URLs generated between them are not compatible (the url path is part of the signature, so the path has to be the same in both).
We've sinse added support for loop-back requests to the S3 container on the proxy network, so we can now use the "s3-$project.altis.dev" hostname from the Tahcyon container, matching the hostname we use from the WordPress applicatio container. It also means we don't need to change the behaviour of the S3 SDK to special-case local development.