Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove trailing comma on function call. #13

Merged
merged 1 commit into from
Apr 18, 2019
Merged

Remove trailing comma on function call. #13

merged 1 commit into from
Apr 18, 2019

Conversation

peterwilsoncc
Copy link
Contributor

No description provided.

@peterwilsoncc peterwilsoncc added the bug Existing functionality isn't behaving as expected label Apr 17, 2019
@peterwilsoncc peterwilsoncc requested a review from joehoyle April 17, 2019 22:35
@joehoyle
Copy link
Member

Wow, is that a fatal? Unsure how this snuck in, unless it's cmpatible with 7.3 or something?

@joehoyle joehoyle merged commit 7e600df into master Apr 18, 2019
@joehoyle joehoyle deleted the hotfix-syntax-error branch April 18, 2019 01:30
@peterwilsoncc
Copy link
Contributor Author

peterwilsoncc commented Apr 18, 2019 via email

@rmccue
Copy link
Member

rmccue commented Apr 18, 2019

Once we go 7.3 minimum, looking forward to adding this to our coding standards 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joehoyle joehoyle joehoyle approved these changes

Assignees
No one assigned
Labels
bug Existing functionality isn't behaving as expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peterwilsoncc @joehoyle @rmccue