Add Database Connection Helper Command #122
Conversation
![hm-linter[bot]](https://avatars.githubusercontent.com/in/5455?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thanks @igmoweb, styling of the output looks good. Just a few little tweaks to do.
inc/composer/class-command.php
Outdated
| $columns, | ||
| $lines | ||
| ), $return_val ); | ||
|
|
||
| return $return_val; | ||
| } | ||
|
|
||
| protected function db( InputInterface $input, OutputInterface $output ) { | ||
| $db = $input->getArgument( 'options' )[0] ?? ''; |
There was a problem hiding this comment.
| $db = $input->getArgument( 'options' )[0] ?? ''; | |
| $db = $input->getArgument( 'options' )[0] ?? null; |
Just going to test this out, I think it's necessary for the default command to run.
There was a problem hiding this comment.
I've tested both ways and it always works but anyway, null looks slightly better
There was a problem hiding this comment.
Ahh of course, the switch doesn't do strict matching. It's a == comparison 👍
inc/composer/class-command.php
Outdated
|
|
||
| exec( "open $output_file_path", $null, $return_val ); | ||
| if ( $return_val !== 0 ) { | ||
| $output->writeln( '<error>You must have Sequel Pro installed to use this command</error>' ); |
There was a problem hiding this comment.
| $output->writeln( '<error>You must have Sequel Pro installed to use this command</error>' ); | |
| $output->writeln( '<error>You must have <href=https://www.sequelpro.com/>Sequel Pro</> installed to use this command</error>' ); |
There was a problem hiding this comment.
I think that <href will only render properly in iTerm2 and GNOME. I don't use either of both and the output looks very ugly. I have added the link between parenthesis if that's ok
There was a problem hiding this comment.
oh me either, yeah good call - I missed that bit in the docs
| passthru( "$base_command mysql --database=wordpress --user=root -pwordpress", $return_val ); | ||
| break; | ||
| default: | ||
| $output->writeln( "<error>The subcommand $db is not recognized</error>" ); |
There was a problem hiding this comment.
| $output->writeln( "<error>The subcommand $db is not recognized</error>" ); | |
| $output->writeln( "<error>The subcommand $db is not recognized</error>" ); | |
| return 1; |
Adding a non zero exit code
There was a problem hiding this comment.
I've assigned 1 to $return_val instead. Although we already have one early return, it can get confusing if we write more code in that function.
There was a problem hiding this comment.
good shout, makes sense to me
There was a problem hiding this comment.
Had to make one small change to the connection type value in the sequel pro XML as it was complaining about missing SSH details but this is all working nicely. Good work @igmoweb 👍
WIP
Issue: #1
composer server dbcomposer server db infocomposer server db spfcomposer server db infosample: