Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Kibana and MailHog links in WP Admin #120

Merged
merged 6 commits into from
Feb 5, 2020
Merged

Added Kibana and MailHog links in WP Admin #120

merged 6 commits into from
Feb 5, 2020

Conversation

igmoweb
Copy link
Contributor

@igmoweb igmoweb commented Feb 4, 2020 •
edited by roborourke
Loading

Captura de pantalla 2020-02-04 a las 11 05 50

Fixes #106

hm-linter[bot]
hm-linter bot suggested changes Feb 4, 2020
View reviewed changes
Copy link

@hm-linter hm-linter bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linting failed (5 errors, 1 warning).

(1 notice occurred in your codebase, but were on files/lines not included in this PR.)

@igmoweb igmoweb requested a review from roborourke February 4, 2020 10:08
roborourke
roborourke requested changes Feb 4, 2020
View reviewed changes
Copy link
Contributor

@roborourke roborourke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor tidy up and an unnecessary env type check but functionality is spot on. I know it's a bit obscure to begin with :)

inc/namespace.php Outdated Show resolved Hide resolved
inc/namespace.php Outdated Show resolved Hide resolved
@igmoweb
Copy link
Contributor Author

igmoweb commented Feb 4, 2020

@roborourke Ready to be reviewed again.

roborourke
roborourke reviewed Feb 4, 2020
View reviewed changes
inc/namespace.php Outdated Show resolved Hide resolved
@igmoweb
Do not check environment in local server main file
f340e5c 
The environment is already checked when local server is loaded
@roborourke roborourke merged commit c9345fe into master Feb 5, 2020
@roborourke roborourke deleted the 106-kibana-mailhog-links branch February 5, 2020 09:39
@roborourke
Copy link
Contributor

Nice one 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hm-linter hm-linter[bot] hm-linter[bot] requested changes

@roborourke roborourke roborourke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add links to kibana and mailhog to WP admin tools menu
2 participants
@igmoweb @roborourke