Don't send empty cookie on every request

[joehoyle]

When not using PHP_XDEBUG_ENABLED, we currently send a blank cookie on every request. This is wasteful, but also means you won't get Batcache locally because of cookies being set, and can snag other problems too.

I don't really see why we even need to set this at all. In this context.

[roborourke]

This is to unset the cookie if previously set when you start without xdebug, so I’d say detect if it’s actually set first then unset it in that scenario. The reason for doing this is so you don’t need one of those browser addons to enable / disable xdebug logging when you start the server with xdebug. Basically avoids an additional manual step.

[joehoyle]

If the cookie is set, but you don’t have code if enabled, why unset it? Seems fine to just stay there?

…

--  Joe Hoyle CTO Human Made

On Fri, Jan 24 2020 at 20:24, Daniel Bachhuber < ***@***.*** > wrote: This is to unset the cookie if previously set when you start without xdebug, so I’d say detect if it’s actually set first then unset it in that scenario. The reason for doing this is so you don’t need one of those browser addons to enable / disable xdebug logging when you start the server with xdebug. Basically avoids an additional manual step. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub ( #116?email_source=notifications&email_token=AABHPE7GWUZCC435KL7GMJDQ7NE63A5CNFSM4KLICVJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJ37NEA#issuecomment-578287248 ) , or unsubscribe ( https://github.com/notifications/unsubscribe-auth/AABHPE4RJO52DCZSQRCTRMDQ7NE63ANCNFSM4KLICVJQ ).

[roborourke]

Good point 🤦‍♂

[roborourke]

Now wondering if we should check whether the XDEBUG_SESSION cookie is set before sending it with a new expiry every time when you do have xdebug enabled.

[joehoyle]

Mmm maybe. Sounds like a follow-up issue / PR :D