Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hostname fails if current dir has a . #35

Closed
joehoyle opened this issue Jun 5, 2019 · 0 comments · Fixed by #40
Closed

Hostname fails if current dir has a . #35

joehoyle opened this issue Jun 5, 2019 · 0 comments · Fixed by #40
Assignees
@joehoyle
Labels
bug Existing functionality isn't behaving as expected

Comments

@joehoyle
Copy link
Member

joehoyle commented Jun 5, 2019

If the current DIR is not a valid subdomain, things fail. E.g. example.com.altis.dev. We should sanitize this.
@joehoyle joehoyle added this to the 2.0 Beta milestone Jun 5, 2019
@roborourke roborourke added the bug Existing functionality isn't behaving as expected label Jun 11, 2019
joehoyle added a commit that referenced this issue Jul 5, 2019
@joehoyle
Allow project subdomain to be configured.
b3291e5 
This will also sanitize the name to be subdomain friedly.

Fixes #35.
@joehoyle joehoyle mentioned this issue Jul 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joehoyle joehoyle

Labels
bug Existing functionality isn't behaving as expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow project subdomain to be configured. humanmade/altis-local-server
2 participants
@roborourke @joehoyle