Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix syntax errors #34

Closed
wants to merge 1 commit into from
Closed

Fix syntax errors #34

wants to merge 1 commit into from

Conversation

robindevitt
Copy link
Contributor

@robindevitt robindevitt commented May 20, 2022

This PR fixes some syntax errors that have been reported on.

PHP Parse error: syntax error, unexpected ')' in dev-tools-command/inc/command/class-command.php on line 817

@joehoyle
Copy link
Member

@robindevitt this error is due to a too old version of PHP (>7.4), but I don't think we support < 7.4 in the latest version of Altis, so I'm not sure why would need to do this (unless someone is erroneously using PHP 7.2 with the latest version of Altis).

@robindevitt
Copy link
Contributor Author

@joehoyle It's for a scenario where a user is currently upgrading from Altis Upgrading from v5 to v11 and they are making use of composer server cli -- altis migrate

@joehoyle
Copy link
Member

@robindevitt hmm ok, I don't think this would be the only place though to support that, it would effectively mean that we need to make sure all of Altis is still compatible with PHP 7.2, which it is not.

altis migrate should be run after composer update, and restarting local-server no? In which case it should be running PHP 7.4 already. I could be wrong, but this sounds like user-error on doing the local-server upgrade if somehow they are not running PHP 7.4 when running altis migrate.

@joehoyle
Copy link
Member

Oh actually, also this would have to do with what version of PHP people had installed locally (not local-server, apoliogies). In which case the next question: when we moved to PHP 7.4 only, did we stipulate that users must also upgrade their host machine's version of PHP?

@robindevitt
Copy link
Contributor Author

Closing this ticket as the reported issue came through a local environment with a potentially older version of php installed causing the errors. Where as they should be using PHP 7.4+.

@mikelittle mikelittle deleted the fix-syntax-errors branch July 1, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants