-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Force the nextrun calculation to use UTC to be consistent with the DB #64
Conversation
Update repo to latest master
The |
This fix resolved the DST scheduling issue in our environment. |
@rmccue can this be looked at so people aren't scrambling when this comes up again in the fall? |
@rmccue @kadamwhite @missjwo what are the next steps to getting this merged? The DST switchover will be happening soon and it would be amazing to prevent this pretty brutal bug from happening to people. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the code here is good. We haven't run into this issue due to setting our server time to UTC but obviously that's not always something that everyone can or should change.
I need to create a tag of the current version first, then we can merge this in and test it out without potentially affecting production instances.
I also 100% agree that the DB, OS, PHP, etc should be using UTC - but sometimes you inherit large systems that are working with their current setup and it'd be tough to change 🙃. Thanks! |
Solves for: humanmade/Cavalcade#74