ELF class upgrades #798
Merged
ELF class upgrades #798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grazfather
reviewed
Jan 20, 2022
- updated types of Phdr attributes - added `classproperty` decorator - updated deprecated ELF constants
- Added `_missing_` functions for `Shdr` and `Phdr` to get a generic case (we don't aim to be a complete elf parser)
Grazfather
approved these changes
Jan 21, 2022
theguy147
requested changes
Jan 24, 2022
There was a problem hiding this comment.
As a side note: I love how easy and quick it was to read the PR (considering the size of it) with the new syntax and type hints.
Just a few small remarks...
Also I wasn't able to mark this line in the review but in L8036 you still use the deprecated get_entry_point(). It should be replaced with something like
- entry = get_entry_point()
- if entry is None:
- return
+ if not gef.binary:
+ return
+ entry = gef.binary.entry_point
theguy147
reviewed
Jan 24, 2022
theguy147
approved these changes
Jan 25, 2022
daniellimws
approved these changes
Jan 25, 2022
Co-authored-by: Daniel Lim Wee Soong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description/Motivation/Screenshots
Bringing some more Python3.6 joy to the
Elfclass and subclass, also benefiting the type hinting, which allows to delete ~100 loc of string printing. Some details:enum.Enumorenum.Flagin theElf,PhdrandShdrclassesget_entry_pointcan now be deprecated in favor ofgef.binary.entry_pointis_arch,is_x86_*) which are way faster now (one lookup and test vsgdb.execute)set_archtoreset_architecture(doesn't return, the result was never used anyway)Elfraise if the binary is corrupted (i.e. bad magic), any GDB won't process itElf.$arch : intwas kept but deprecated (since they are property we can't use the decorator, so if you have ideas 😄 )How Has This Been Tested?
make testChecklist
devbranch, notmaster.