-
-
Notifications
You must be signed in to change notification settings - Fork 756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add number arg for 'heap chunk' command #745
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Could you also update the documentation, and the help message? It wasn't immediately clear to me at the start what this argument does.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
The code though needs to be updated. Also you're missing adding unit test cases, please provide some.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM
add number arg for 'heap chunk command'
Description/Motivation/Screenshots
add a number argument for heap chunk command which is usable for statically linked binary. There is no need to know the main_arena address and mp_ address for heap chunks, just chunk address and number.
How Has This Been Tested?
make test
Checklist
dev
branch, notmaster
.