Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update and fix
heap
commandDescription/Motivation/Screenshots
This PR is part of #693 and covers the following points:
set-arena
subcommand to theheap
help message.heap chunks
command from a simple conversion toint
to useparse_address()
instead.heap bins fast
command output in documentation.test_cmd_heap_bins_fast
test to actually look for a fastbin in the output. To do this theheap-fastbins.c
had to be changed to first fill all 7 tcache bins before freeing the actual fastbin to look for.EDIT:
heap-fastbins.c
doesn't need to be udpated when disabling tcache via the environment in GDB:set environment GLIBC_TUNABLES glibc.malloc.tcache_count=0
(as pointed out to me by @irontigran )How Has This Been Tested?
make test
Checklist
dev
branch, notmaster
.