Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test PR to try out review suggestions #37

Closed
wants to merge 1 commit into from
Closed

Test PR to try out review suggestions #37

wants to merge 1 commit into from

Conversation

hugovk
Copy link
Owner

@hugovk hugovk commented Dec 21, 2021

Quick sandbox PR for playing with GitHub's feature to submit a review in one step.

Here's how!

  1. Click the files changed tab.

  2. Click "+" next to a line you want to comment. Either enter just comment:

image

  1. ... or for extra points, you can click the little +- icon on the left and it add a suggestion with the existing line. Change it to what you like!

image

  1. The preview shows the suggestion as a diff

image

  1. Next if you only have one comment on the PR, just press "Add single comment" -> email sent for this single comment.

  2. Or if you have more to do, press "Start a review"

  3. Repeat for other suggestions

  4. When ready, click "Review changes" at the top right. Summarise your review and "Comment" (or "Request changes" or "Approve") and it posts all the review comments at once -> single email sent for all the comments.

Docs: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/commenting-on-a-pull-request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant