fix(rpc): only cache lookups when finalized

hugomrdias · Oct 24, 2024 · 73051aa · 73051aa
1 parent 687eba6
commit 73051aa
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/packages/iso-filecoin/src/address.js b/packages/iso-filecoin/src/address.js
@@ -349,7 +349,7 @@ class Address {
     }
 
     const cached = await /** @type {typeof cache.get<string>}*/ (cache.get)(key)
-    if (cached) {
+    if (cached && options.safety === 'finalized') {
       return AddressId.fromString(cached)
     }
 
@@ -371,7 +371,9 @@ class Address {
       )
     }
 
-    await cache.set(key, idAddress.toString())
+    if (options.safety === 'finalized') {
+      await cache.set(key, idAddress.toString())
+    }
     return idAddress
   }
 
@@ -392,7 +394,7 @@ class Address {
     const cache = getCache(options.cache)
     const key = ['0x', this.toString()]
     const cached = await /** @type {typeof cache.get<string>}*/ (cache.get)(key)
-    if (cached) {
+    if (cached && options.safety === 'finalized') {
       return cached
     }
 
@@ -410,7 +412,9 @@ class Address {
       throw new Error(`Invalid ID masked 0x address: ${r.result}`)
     }
 
-    await cache.set(key, r.result)
+    if (options.safety === 'finalized') {
+      await cache.set(key, r.result)
+    }
     return r.result
   }
 }