Cleanup package.json (emscripten-core#7536)

This is part of a larger change to remove the two checked in
node_modules trees that we have in the emscripten and rely instead
on developers running `npm install` after cloning/syncing.

- Switch ws dependency to devDevpendency since its only used
  for testing
- Add private:true since we are not (yet) publishing emscripten as
  a node package.
- Remove running on npm install from sockets test;  We can rely on
  developers doing this before running the tests.
- Don't try to run npm install in test_sockets.py.  Assume that
  developers to used "git clone" will also run npm install

package.json

@@ -1,7 +1,6 @@
 {
-  "name": "emscripten",
-  "version": "1.13.0",
-  "dependencies": {
+  "private": true,
+  "devDependencies": {
     "ws": "~0.4.28"
   }
 }

tests/sockets/test_sockets_echo_client.c

@@ -210,7 +210,7 @@ int main() {
     sprintf(buffer, "%s:%u", inet_ntoa(adr_inet.sin_addr), (unsigned)ntohs(adr_inet.sin_port));
     // TODO: This is not the correct result: We should have a auto-bound address
     char *correct = "0.0.0.0:0";
-    printf("got (expected) socket: %s (%s), size %d (%d)\n", buffer, correct, strlen(buffer), strlen(correct));
+    printf("got (expected) socket: %s (%s), size %lu (%lu)\n", buffer, correct, strlen(buffer), strlen(correct));
     assert(strlen(buffer) == strlen(correct));
     assert(strcmp(buffer, correct) == 0);
   }
@@ -228,7 +228,7 @@ int main() {
     sprintf(buffer, "%s:%u", inet_ntoa(adr_inet.sin_addr), (unsigned)ntohs(adr_inet.sin_port));
     char correct[1000];
     sprintf(correct, "127.0.0.1:%u", SOCKK);
-    printf("got (expected) socket: %s (%s), size %d (%d)\n", buffer, correct, strlen(buffer), strlen(correct));
+    printf("got (expected) socket: %s (%s), size %lu (%lu)\n", buffer, correct, strlen(buffer), strlen(correct));
     assert(strlen(buffer) == strlen(correct));
     assert(strcmp(buffer, correct) == 0);
   }

tests/test_sockets.py

@@ -19,7 +19,7 @@
 from tools import shared
 from tools.shared import PYTHON, EMCC, NODE_JS, path_from_root, Popen, PIPE, WINDOWS, run_process, run_js, JS_ENGINES, CLANG_CC
 
-node_ws_module_installed = False
+npm_checked = False
 
 NPM = os.path.join(os.path.dirname(NODE_JS[0]), 'npm.cmd' if WINDOWS else 'npm')
 
@@ -102,15 +102,11 @@ def __init__(self, filename, args, listen_port):
   def __enter__(self):
     # assuming this is only used for WebSocket tests at the moment, validate that
     # the ws module is installed
-    child = run_process(NODE_JS + ['-e', 'require("ws");'], check=False)
-    global node_ws_module_installed
-    # Attempt to automatically install ws module for Node.js.
-    if child.returncode != 0 and not node_ws_module_installed:
-      node_ws_module_installed = True
-      run_process([NPM, 'install', path_from_root('tests', 'sockets', 'ws')], cwd=os.path.dirname(EMCC))
-      # Did installation succeed?
+    global npm_checked
+    if not npm_checked:
       child = run_process(NODE_JS + ['-e', 'require("ws");'], check=False)
-    assert child.returncode == 0, 'ws module for Node.js not installed, and automatic installation failed! Please run \'npm install\' from %s' % shared.__rootpath__
+      assert child.returncode == 0, '"ws" node module not found.  you may need to run npm install'
+      npm_checked = True
 
     # compile the server
     proc = run_process([PYTHON, EMCC, path_from_root('tests', self.filename), '-o', 'server.js', '-DSOCKK=%d' % self.listen_port] + self.args)