-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow building with elogind #178
base: main
Are you sure you want to change the base?
Conversation
This makes the runtime systemd dep requirement optional when building with -Dsystemd=true so that colord can be built with support for libsystemd on distros that use elogind. There should be no impact here when building colord on distros that use systemd, both libsystemd and systemd should exist in that case.
Why can't we use |
@hughsie because the meson doesn't pull in libsystemd (and Sorry this might not be obvious, but elogind provides libsystemd.pc and is compatible with libsystemd |
Then I'm double confused; why can't systems using elogind just use |
Because So this patch makes that 'systemd' dependency optional so it builds on systems with elogind, but still supports finding libsystemd (which elogind can provide) when using |
I think elogind either needs to provide full compatibility with systemd or none; providing one of the two pkg-config files is super weird and adds to the maintenance burden. |
Ya I don't disagree, but I'm in no position to change elogind's behavior and patching colord this way was much simpler and straight forward. It's fine if you want to NAK this patch, we are using it anyways in Alpine Linux, I just thought you might want it since we aren't the only distro using elogind (and no systemd) 😁
…On January 9, 2025 3:37:03 AM PST, Richard Hughes ***@***.***> wrote:
I think elogind either needs to provide full compatibility with systemd or none; providing one of the two pkg-config files is super weird and adds to the maintenance burden.
|
This makes the runtime systemd dep requirement optional when building with -Dsystemd=true so that colord can be built with support for libsystemd on distros that use elogind. There should be no impact here when building colord on distros that use systemd, both libsystemd and systemd should exist in that case.