Remove hard-coded pad token id in distilbert and albert #3965
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the config adds
pad_token_id
attribute,padding_idx
set the value ofconfig.pad_token_id
in BertEmbedding. ( PR #3793 )But it seems that not only the config of
Bert
, but also that ofDistilBert
andAlbert
haspad_token_id
. (Distilbert config, Albert config)But in Embedding class of Distilbert and Albert, it seems that
padding_idx
is still hard-coded. So I've fixed those parts.