Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OS err #36094

Merged
merged 2 commits into from
Feb 7, 2025
Merged

Fix OS err #36094

merged 2 commits into from
Feb 7, 2025

Conversation

muellerzr
Copy link
Contributor

What does this PR do?

There's an issue with #35580 where if we have too many GPUs, we hit race conditions while trying to do the os.rename/move. Since we only need this once per node, really it just needs to happen under args.should_save (since that will make it happen only once per node or per instance as a whole if not doing save-on-each-node).

This PR fixes this race condition.

I tested it on the cluster on 8 GPUs, which replicated the issue

Fixes #36076

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@SunMarc

@muellerzr muellerzr requested a review from SunMarc February 7, 2025 14:48
Copy link
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. Let's wait a bit to see if this fixes the issue you linked !

@muellerzr muellerzr merged commit ba29a43 into main Feb 7, 2025
26 checks passed
@muellerzr muellerzr deleted the muellerzr-os-err branch February 7, 2025 14:57
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trainer saving checkpoint crashes in multi-gpu (DDP): OSError: [Errno 39] Directory not empty
3 participants