Let server decide default repo visibility #34999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: CI seems to be failing but I don't think it's related to this PR > python3 .circleci/parse_test_outputs.py --file tests_output.txt --fail
1 failed because `AssertionError: 0.0002062409 not less than or equal to 0.0002 : outputs.logits` -> Difference between PyTorch and TF is 0.00020624090393539518 (>= 0.0002) for Data2VecVisionForSemanticSegmentation
1 failed because `AssertionError: 1.9396484e-05 not less than or equal to 1e-05 : outputs.hidden_states_1` -> Difference between PyTorch and TF is 1.9396484276512638e-05 (>= 1e-05) for SwiftFormerModel
Number of failed tests: 2 |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ArthurZucker
approved these changes
Nov 28, 2024
|
(can I let you merge it? I don't have permissions myself since failing CI) |
|
Of course! |
BernardZach
pushed a commit
to BernardZach/transformers
that referenced
this pull request
Dec 5, 2024
* Let server decide default repo visibility * code style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, all repos were public by default when created without passing the
privateargument. This meant that passingprivate=Falseorprivate=Nonewas strictly the same. This is not the case anymore. Enterprise Hub offers organizations to set a default visibility setting for new repos. This is useful for organizations forbidding public repos for security matters. This PR mostly updates some docstrings + the default value forhub_private_repoin Trainer's args.This PR doesn't create any breaking change. The real update has been done server-side when introducing the new Enterprise Hub feature. Related to huggingface/huggingface_hub#2679.