-
Notifications
You must be signed in to change notification settings - Fork 27.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
making gpt2 fx traceable #34633
making gpt2 fx traceable #34633
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, do you mind running make fix-copies
?
746d252
to
3e612a9
Compare
3e612a9
to
5a3437c
Compare
This reverts commit 5a3437c.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
This indeed fixes the issue of: TraceError: Proxy object cannot be iterated. This can be attempted when the Proxy is used in a loop or as a *args or **kwargs function argument. See the torch.fx docs on pytorch.org for a more detailed explanation of what types of control flow can be traced, and check out the Proxy docstring for help troubleshooting Proxy iteration errors |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
* making gpt2 fx tracable * running make fix-copies * Revert "running make fix-copies" This reverts commit 5a3437c.
* making gpt2 fx tracable * running make fix-copies * Revert "running make fix-copies" This reverts commit 5a3437c.
What does this PR do?
This PR fixes the issue that gpt2 is no longer fx traceable in the latest version
Below code gives error complaining about control flows not traceable. This PR solves the issue.
Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@ArthurZucker