avoid calling gc.collect and cuda.empty_cache
#34514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rocketknight1
approved these changes
Oct 30, 2024
There was a problem hiding this comment.
Yes, this seems like a good speed fix! cc @LysandreJik @ArthurZucker for core maintainer review
ydshieh
changed the title
gc.collect and cuda.empty_cache
LysandreJik
approved these changes
Oct 31, 2024
|
Yes, a helper method is nice. Will update |
ydshieh
force-pushed
the
speed_no_empty
branch
from
82e3add to
6620320
Compare
|
updated. So far it doesn't call |
ydshieh
force-pushed
the
speed_no_empty
branch
from
6620320 to
4403c5a
Compare
ydshieh
force-pushed
the
speed_no_empty
branch
from
1f47700 to
18d6d5d
Compare
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
2015aroras
pushed a commit
to 2015aroras/transformers
that referenced
this pull request
Nov 15, 2024
* update * update * update * update * update --------- Co-authored-by: ydshieh <[email protected]>
BernardZach
pushed a commit
to BernardZach/transformers
that referenced
this pull request
Dec 5, 2024
* update * update * update * update * update --------- Co-authored-by: ydshieh <[email protected]>
BernardZach
pushed a commit
to innovationcore/transformers
that referenced
this pull request
Dec 6, 2024
* update * update * update * update * update --------- Co-authored-by: ydshieh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Let's avoid calling
gc.collectandcuda.empty_cachewhile the tests are running on CPU:Running on GPT2 tests,
60 seconds on main, 20 seconds on this PR