Add post_process_depth_estimation for GLPN
#34413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
Thanks! Could you remove the following block, thanks! (in @unittest.skip(reason="Failing after #32550")
def test_pipeline_depth_estimation(self):
pass
@unittest.skip(reason="Failing after #32550")
def test_pipeline_depth_estimation_fp16(self):
passThey pass now indeed. |
alex-bene
force-pushed
the
glpn_depth_fix
branch
from
eb7a782 to
3133285
Compare
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
alex-bene
force-pushed
the
glpn_depth_fix
branch
from
65f7ddd to
206df44
Compare
|
@ArthurZucker ready to merge? |
7 tasks
BernardZach
pushed a commit
to BernardZach/transformers
that referenced
this pull request
Dec 5, 2024
* add depth postprocessing for GLPN * remove previous temp fix for glpn tests * Style changes for GLPN's `post_process_depth_estimation` Co-authored-by: Arthur <[email protected]> * additional style fix --------- Co-authored-by: Arthur <[email protected]>
BernardZach
pushed a commit
to innovationcore/transformers
that referenced
this pull request
Dec 6, 2024
* add depth postprocessing for GLPN * remove previous temp fix for glpn tests * Style changes for GLPN's `post_process_depth_estimation` Co-authored-by: Arthur <[email protected]> * additional style fix --------- Co-authored-by: Arthur <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a post_process_depth_estimation method for the image processor of GLPN (thus fixing its inference via the depth pipeline) and updates its docs.
Fixes #34300 and comment on #32550
Before submitting
Pull Request section?
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@ydshieh @qubvel @amyeroberts