Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix torch.fx issue related to the new loss_kwargs keyword argument #34380

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

michaelbenayoun
Copy link
Member

What does this PR do?

As per title. This was introduced in #34283.

cc @ArthurZucker @muellerzr

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Contributor

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! :)

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am ashamed by how simple the fix is !
Can you remove the skip related to it? 🤗

THanks!

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks let's merge!

@ArthurZucker ArthurZucker merged commit 1c5918d into huggingface:main Oct 24, 2024
17 of 20 checks passed
@michaelbenayoun michaelbenayoun deleted the fix_fx_for_loss_kwargs branch October 25, 2024 10:02
ArthurZucker pushed a commit that referenced this pull request Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants