-
Notifications
You must be signed in to change notification settings - Fork 27.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor StarCoder2 using modular #34015
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
3ae88e1
to
6bfdcb7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super nice! Just need clarification about magic comment!
utils/modular_model_converter.py
Outdated
new_body.extend(self.update_body(self.original_methods[func_name].body.body, node.body[i + 1 :])) | ||
new_body = self._fix_init_location(new_body) | ||
comment = expr.trailing_whitespace.comment | ||
# If we have a magic comment, do not unravel the call to super and just remove the comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's a magic comment ?
8225603
to
db2cdc4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for removing the # no unravel
a lot better IMO
* Create modular_starcoder2.py * Update modular_starcoder2.py * update * finalize modular * revert # no-unravel * Add support * style * Update modular_model_converter.py * update docstring
* Create modular_starcoder2.py * Update modular_starcoder2.py * update * finalize modular * revert # no-unravel * Add support * style * Update modular_model_converter.py * update docstring
What does this PR do?
Refactor StarCoder2 to remove all the copied-from and use modular instead.