fix qwen2vl vision eager-attention #33213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ArthurZucker @zucchini-nlp we made a quick fix of eager attention impl in qwen2vl. |
Co-authored-by: Arthur <[email protected]>
|
Hi @ArthurZucker, commit as you suggested, sorry for the late reply bc my vacation week. |
|
Hi, @zucchini-nlp @ArthurZucker , If you have any further questions about this fix, feel free to let us know! 👀 |
This was referenced Sep 5, 2024
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
Sorry everyone for merging a bit later 🤗 |
zucchini-nlp
pushed a commit
to zucchini-nlp/transformers
that referenced
this pull request
Sep 6, 2024
* fix-qwen2vl-vision-eager-attention * code-quality * Update src/transformers/models/qwen2_vl/modeling_qwen2_vl.py Co-authored-by: Arthur <[email protected]> * code-quality --------- Co-authored-by: Arthur <[email protected]>
itazap
pushed a commit
to NielsRogge/transformers
that referenced
this pull request
Sep 20, 2024
* fix-qwen2vl-vision-eager-attention * code-quality * Update src/transformers/models/qwen2_vl/modeling_qwen2_vl.py Co-authored-by: Arthur <[email protected]> * code-quality --------- Co-authored-by: Arthur <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.