Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌐 [i18n-KO] Update README_ko.md #33098

Merged
merged 14 commits into from
Nov 4, 2024
Merged

🌐 [i18n-KO] Update README_ko.md #33098

merged 14 commits into from
Nov 4, 2024

Conversation

J4BEZ
Copy link
Contributor

@J4BEZ J4BEZ commented Aug 23, 2024 •
edited
Loading

Delete the blank paragraph in the language selection button and Edit to synchronize with the English version of README.md

What does this PR do?

Delete an empty paragrah under the language selection by removing white space.
And synchronize README_ko.md to README.md.

  • Additional edit for keep consistency with main documentation.
    (메인 문서와 일관성 유지를 위한 수정)
  • Grammar Check (맞춤법 검사)
  • Maintain the content of the existing document as much as possible.
  • Juxtapose in English of some tasks.

There could be mistranslations or awkwardness.
If you found any of them, I would appreciate it if you could correct the error to make the community shine🙇‍♂️

Thanks for your hard effort that everyone can enjoy thousands of models and learn DL more easily!

I'm sorry to find this PR late #20179
(굉장히 좋은 가이드가 있었군요! 늦게 확인해서 죄송합니다😅)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

J4BEZ added 3 commits August 24, 2024 00:17
@J4BEZ
Update README_ko.md
ad397c0 
Delete the blank paragraph in the language selection button and Edit to synchronize with the English version of README.md
@J4BEZ
Merge branch 'huggingface:main' into doc/edit_README_ko_md
7865924
@J4BEZ
[i18n-KO] Update README_ko.md
d73676e 
* Additional edit for keep consistency with main [documentation](https://huggingface.co/docs/transformers/v4.44.2/ko/index). (메인 문서와 일관성 유지를 위한 수정)
@J4BEZ J4BEZ changed the title Update README_ko.md [i18n-KO] Update README_ko.md Aug 24, 2024
J4BEZ added 4 commits August 26, 2024 22:07
@J4BEZ
Update README_ko.md
a4a6e38 
Additional update.
* Change docs link to Korean translated page if it exists.
@J4BEZ
Change doc link to korean translated if it exists.
76d1169 
Change the link of doc and delete a row 'migration' of the table Learn more[더 알아보기], since it does not exist in the main version of doc.
@J4BEZ
modify a link of the main README.md
15bf1d4 
from
`https://huggingface.co/docs/transformers/index#supported-frameworks`

to
`https://huggingface.co/docs/transformers/index#supported-models-and-frameworks`

since the title of 'supported table' changed.
@J4BEZ
[i18n-ko] edit links and sync with main README.md
76f7054
@J4BEZ J4BEZ marked this pull request as draft August 27, 2024 14:50
@J4BEZ J4BEZ changed the title [i18n-KO] Update README_ko.md 🌐 [i18n-KO] Update README_ko.md Aug 27, 2024
heuristicwave
heuristicwave reviewed Aug 31, 2024
View reviewed changes
i18n/README_ko.md Outdated Show resolved Hide resolved
heuristicwave
heuristicwave reviewed Aug 31, 2024
View reviewed changes
i18n/README_ko.md Outdated Show resolved Hide resolved
heuristicwave
heuristicwave reviewed Aug 31, 2024
View reviewed changes
Copy link
Contributor

@heuristicwave heuristicwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

안녕하세요 @J4BEZ 님, 소중한 변역 감사합니다!

이전에 코드의 주석도 번역하라는 가이드가 있어 변경해보았습니다!

edit_README_ko 에서 README.md 파일도 수정한 것은 Update README_ko.md 과는 분리하는게 좋아보입니다!
@junejae @jungnerd @harheem @nuatmochoi 의견 부탁드려요~

J4BEZ and others added 3 commits August 31, 2024 21:41
@J4BEZ @heuristicwave
docs/change comment to Korean1
465dd33 
Change English comment to Korean

Co-authored-by: Jihun Lim <[email protected]>
@J4BEZ @heuristicwave
docs/change comment to Korean2
2d950e1 
Change English comment to Korean

Co-authored-by: Jihun Lim <[email protected]>
@J4BEZ
revise to original
632f148 
to seperate `edit_README_ko_md` and `README.md`
@J4BEZ
Copy link
Contributor Author

J4BEZ commented Aug 31, 2024

@heuristicwave 섬세한 피드백 너무나 감사드립니다🙇‍♂️!!
리뷰하여 주신대로 코드에 나타난 주석을 번역해주신 제안으로 수정하였으며
한국어 README.md에만 집중될 수 있도록 영문 README.md 파일의 링크는 원본으로 되돌렸습니다😆😆

이번 한 주 고생 많으셨습니다🙇‍♂️
토요일 밤, 하루 잘 마무리 하시고 복되고 평안한 주말 되시길 바랍니다🤗

@Rocketknight1
Copy link
Member

cc @stevhliu for vis

stevhliu
stevhliu approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for updating! Feel free to mark as ready for review when you're done 🤗

@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@J4BEZ
Copy link
Contributor Author

J4BEZ commented Oct 31, 2024

@stevhliu Thank you for your kind reply😄
I'll change this PR from Draft to Ready for review soon, after adjusting some improvements!

Thank you for your hard effort and hope you have a great day😄

J4BEZ added 2 commits November 3, 2024 18:29
@J4BEZ
Synchronization with English documentation.
23f3e41 
Synchronization with English documentation, and translated a line of comment from English to Korean.
@J4BEZ
Merge branch 'main' into doc/edit_README_ko_md
40eb49f
@J4BEZ
Copy link
Contributor Author

J4BEZ commented Nov 3, 2024

@stevhliu Thank you for waiting😆
I finished translation and synchronization🙌🙌

Hope you have a peaceful day and stay healthy!

@J4BEZ J4BEZ marked this pull request as ready for review November 3, 2024 14:41
@stevhliu stevhliu merged commit 0a6795a into huggingface:main Nov 4, 2024
9 checks passed
2015aroras pushed a commit to 2015aroras/transformers that referenced this pull request Nov 15, 2024
@J4BEZ @heuristicwave @2015aroras
🌐 [i18n-KO] Update README_ko.md (huggingface#33098)
a93091c 
* Update README_ko.md

Delete the blank paragraph in the language selection button and Edit to synchronize with the English version of README.md

* [i18n-KO] Update README_ko.md

* Additional edit for keep consistency with main [documentation](https://huggingface.co/docs/transformers/v4.44.2/ko/index). (메인 문서와 일관성 유지를 위한 수정)

* Update README_ko.md

Additional update.
* Change docs link to Korean translated page if it exists.

* Change doc link to korean translated if it exists.

Change the link of doc and delete a row 'migration' of the table Learn more[더 알아보기], since it does not exist in the main version of doc.

* modify a link of the main README.md

from
`https://huggingface.co/docs/transformers/index#supported-frameworks`

to
`https://huggingface.co/docs/transformers/index#supported-models-and-frameworks`

since the title of 'supported table' changed.

* [i18n-ko] edit links and sync with main `README.md`

* docs/change comment to Korean1

Change English comment to Korean

Co-authored-by: Jihun Lim <[email protected]>

* docs/change comment to Korean2

Change English comment to Korean

Co-authored-by: Jihun Lim <[email protected]>

* revise to original

to seperate `edit_README_ko_md` and `README.md`

* Synchronization with English documentation.

Synchronization with English documentation, and translated a line of comment from English to Korean.

---------

Co-authored-by: Jihun Lim <[email protected]>
BernardZach pushed a commit to BernardZach/transformers that referenced this pull request Dec 5, 2024
@J4BEZ @heuristicwave @BernardZach
🌐 [i18n-KO] Update README_ko.md (huggingface#33098)
f34686a 
* Update README_ko.md

Delete the blank paragraph in the language selection button and Edit to synchronize with the English version of README.md

* [i18n-KO] Update README_ko.md

* Additional edit for keep consistency with main [documentation](https://huggingface.co/docs/transformers/v4.44.2/ko/index). (메인 문서와 일관성 유지를 위한 수정)

* Update README_ko.md

Additional update.
* Change docs link to Korean translated page if it exists.

* Change doc link to korean translated if it exists.

Change the link of doc and delete a row 'migration' of the table Learn more[더 알아보기], since it does not exist in the main version of doc.

* modify a link of the main README.md

from
`https://huggingface.co/docs/transformers/index#supported-frameworks`

to
`https://huggingface.co/docs/transformers/index#supported-models-and-frameworks`

since the title of 'supported table' changed.

* [i18n-ko] edit links and sync with main `README.md`

* docs/change comment to Korean1

Change English comment to Korean

Co-authored-by: Jihun Lim <[email protected]>

* docs/change comment to Korean2

Change English comment to Korean

Co-authored-by: Jihun Lim <[email protected]>

* revise to original

to seperate `edit_README_ko_md` and `README.md`

* Synchronization with English documentation.

Synchronization with English documentation, and translated a line of comment from English to Korean.

---------

Co-authored-by: Jihun Lim <[email protected]>
BernardZach pushed a commit to innovationcore/transformers that referenced this pull request Dec 6, 2024
@J4BEZ @heuristicwave @BernardZach
🌐 [i18n-KO] Update README_ko.md (huggingface#33098)
eb91fff 
* Update README_ko.md

Delete the blank paragraph in the language selection button and Edit to synchronize with the English version of README.md

* [i18n-KO] Update README_ko.md

* Additional edit for keep consistency with main [documentation](https://huggingface.co/docs/transformers/v4.44.2/ko/index). (메인 문서와 일관성 유지를 위한 수정)

* Update README_ko.md

Additional update.
* Change docs link to Korean translated page if it exists.

* Change doc link to korean translated if it exists.

Change the link of doc and delete a row 'migration' of the table Learn more[더 알아보기], since it does not exist in the main version of doc.

* modify a link of the main README.md

from
`https://huggingface.co/docs/transformers/index#supported-frameworks`

to
`https://huggingface.co/docs/transformers/index#supported-models-and-frameworks`

since the title of 'supported table' changed.

* [i18n-ko] edit links and sync with main `README.md`

* docs/change comment to Korean1

Change English comment to Korean

Co-authored-by: Jihun Lim <[email protected]>

* docs/change comment to Korean2

Change English comment to Korean

Co-authored-by: Jihun Lim <[email protected]>

* revise to original

to seperate `edit_README_ko_md` and `README.md`

* Synchronization with English documentation.

Synchronization with English documentation, and translated a line of comment from English to Korean.

---------

Co-authored-by: Jihun Lim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heuristicwave heuristicwave heuristicwave left review comments

@stevhliu stevhliu stevhliu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@J4BEZ @Rocketknight1 @HuggingFaceDocBuilderDev @heuristicwave @stevhliu