Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove irrelevant comment in _update_causal_mask #32363

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fxmarty
Copy link
Contributor

@fxmarty fxmarty commented Jul 31, 2024

Forgot to push a commit to #32227, my bad!

Feel free to merge this one if approved!

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for handling!

As this changes the if condition, could you run the slow tests for all the model affected?

You'll need to:

  • add the run-slow label to the PR
  • push a commit with [run_slow] list of model name (space separated list of the model names)

@ArthurZucker ArthurZucker removed their request for review November 20, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants