Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add scaling_factor to GemmaRotaryEmbedding for fix error in GemmaLine… #32141

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nprotasov
Copy link

In generated code, there are GemmaLinearScalingRotaryEmbedding and GemmaDynamicNTKScalingRotaryEmbedding which use scaling_factor need to declare it in base class, or remove generation of: GemmaLinearScalingRotaryEmbedding and GemmaDynamicNTKScalingRotaryEmbedding

@amyeroberts
Copy link
Collaborator

cc @ArthurZucker @gante

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that is only modifying the diff, the modeling needs to be updated as well with python utils/dif_converter.py --files_to_parse src/transformers/models/gemma/diff_gemma.py

@nprotasov
Copy link
Author

@ArthurZucker I run: python utils/diff_model_converter.py --files_to_parse src/transformers/models/gemma/diff_gemma.py
But got error: FileNotFoundError: [Errno 2] No such file or directory: 'ruff'
What is ruff file?

@gante
Copy link
Member

gante commented Jul 27, 2024

This PR can be merged, but will quickly be superseded by #31999 :D

(@nprotasov in the PR I linked, Gemma will gain access to all RoPE scaling strategies :) )

Copy link

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants