-
Notifications
You must be signed in to change notification settings - Fork 27.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate: handle logits_warper
update in models with custom generate fn
#31957
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @gante, thanks for standardizing with the current logic!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks fixing and standardizing our generation logic!
…e fn (huggingface#31957) handle logits_warper update in models with custom generate fn
…e fn (huggingface#31957) handle logits_warper update in models with custom generate fn
…e fn (huggingface#31957) handle logits_warper update in models with custom generate fn
…e fn (huggingface#31957) handle logits_warper update in models with custom generate fn
…e fn (#31957) handle logits_warper update in models with custom generate fn
What does this PR do?
Oops, #31956 written by me broke some models with custom
generate
loop (logits_warper
is no longer optional).This PR corrects failing models, and takes the opportunity to standardize (i.e. copy-paste patterns)
generate
on musicgen models.cc @ylacombe