-
Notifications
You must be signed in to change notification settings - Fork 27.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests] fix deepspeed zero3 config for test_stage3_nvme_offload
#31881
Conversation
OK for me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me - thanks for fixing!
Hi @ydshieh , could you take a look at this PR? Thx! |
Oh, that's a mis-click. This is the correct line: https://github.com/huggingface/accelerate/blob/main/src/accelerate/accelerator.py#L3278 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
What does this PR do?
Since we manually modified the original zero3 config value here, we will end up with a ValueError in accelerate (code).
For Zero3 Checkpointing, we need to turn this value to True.
@amyeroberts and @ydshieh