Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation for Gemma2. #31682

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Conversation

jbornschein
Copy link
Contributor

@jbornschein jbornschein commented Jun 28, 2024

Model sizes and Blog post URL are wrong in the documentation.

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Model sizes and Blog post URL are wrong in the documentation.
Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating!

cc @ArthurZucker to confirm

docs/source/en/model_doc/gemma2.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah thanks!

@jbornschein
Copy link
Contributor Author

Should be ready to go...

@amyeroberts
Copy link
Collaborator

I'm going to merge without retriggering a CI run as it's just a doc change

@amyeroberts amyeroberts merged commit f91c16d into huggingface:main Jul 2, 2024
1 check failed
@jbornschein jbornschein deleted the patch-1 branch July 3, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants