don't zero out the attention_mask when using sliding window with flash attention #31670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArthurZucker
approved these changes
Jun 28, 2024
|
Thanks 🤗 |
ArthurZucker
pushed a commit
that referenced
this pull request
Jun 28, 2024
…h attention (#31670) * don't zero out the attention_mask when using sliding window with flash attention * chore: lint
|
Checkout https://pypi.org/project/transformers/4.42.2/ which includes this commit! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Flash attention has it's own sliding window argument, but currently the attention_mask is clobbered with sliding window leading to incorrect/large loss values (and also breaks sample packing in axolotl):
Here's the existing loss with flash attention and no sample packing (LoRA):
Here's the loss with the fix (no sample packing):
Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@muellerzr @SunMarc @ArthurZucker