-
Notifications
You must be signed in to change notification settings - Fork 27.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add gather_use_object arguments #31514
add gather_use_object arguments #31514
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this 🤗
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @SangbumChoi ! I left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! Just one final nit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for iterating ! I left a small suggestion !
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Co-authored-by: Marc Sun <[email protected]>
@SunMarc Thanks for the clean code! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! Thanks for iterating !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this!
Logic looks OK, but we should move where it happens. A test should be added too, to make sure this argument can be passed and is respected
@amyeroberts For the test part where should I add for the extra kwargs or arguments? https://github.com/huggingface/transformers/blob/main/tests/trainer/test_trainer.py Maybe here? |
@SangbumChoi Yep - test_trainer.py is perfect 👌 It might be hard to verify if the argument is respected, but if we can pass |
@amyeroberts @SunMarc Even though the CI says pass the test I'm little bit skeptical about where did the Do I need some extra flag or commit for this? |
@SangbumChoi The test_trainer.py tests should run in the test_torch run. If you look at the test artefacts e.g. the test_outputs.txt for the parallel run 1, you can find the |
@amyeroberts I think I don't have access to test_outputs.txt for the parallel run 1, but I confirmed that the CI passed. Thanks again for the detail description!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this feature + tests!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for iterating !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR! I didn't get a chance to take a look at this as I was OOO. Please see my comments here as I think we need a follow-up to avoid bad practices + clarify this very, very specific use-case
What does this PR do?
Fixes #30766 (issue)
I have described the problem and the solution at the issue!
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@muellerzr and @SunMarc