-
Notifications
You must be signed in to change notification settings - Fork 27.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix bug] logits's shape different from label's shape in preprocess_logits_for_metrics #31447
Conversation
Oh, that's true. @SunMarc yes, should be safe. Alternatively, we can just move the "if" block with labels padding before the "if" block with logits. |
Yeah, I think that's would be better for readability + it was the previous behavior ! Could you make the change @wiserxin ? |
sure |
labels can't use `gather` before pass to `preprocess_logits_for_metrics`, so must split into 2 if-block
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! Thanks for the PR @wiserxin !
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing!
+1 on @qubvel's comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a bunch!
What does this PR do?
After update my tranformers 4.39.3 --> 4.41.2, training LLM with deepspeed DDP method, something wrong when it goes to my
preprocess_logits_for_metrics
function: logits's shape is different from label's shape.Then i discover that in latest trainer code, before passing to preprocess_logits_for_metrics, logits are padded by function
pad_across_processes
but labels are not.It seems like a bug unexpectedly introduced .
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.