-
Notifications
You must be signed in to change notification settings - Fork 27.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[QoL fix] [Image processing] Add warning on assumption of channel dim #31364
Conversation
Use PIL info whenever possible to decide channel axis
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this! Flagging the ambiguous case is a good idea, although I suspect a very rare case (it implies the image has height or width dimension of 1 or 3).
Improve warning message
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for iterating!
Just some tweaks and should be ready to merge
Co-authored-by: amyeroberts <[email protected]>
Co-authored-by: amyeroberts <[email protected]>
Co-authored-by: amyeroberts <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this warning and iterating on this!
Sometimes the input image can have height or width 1 and in HWC format. One example is if you
np.asarray(PIL.Image)
. The current function to infer channel dim assumes the CHW silently which can cause confusion to users as the image will be wrongly processed as a grayscale image, which will raise further, harder to interpret errors when running through models.This PR adds a warning when this happens.
It also set the channel dim to last if inputs are PIL.Image as they are always in HWC afternp.asarray
, avoiding ambiguity in this case.The default behaviour of assuming first dim as the channel has not changed to prevent any breaking changes.
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@amyeroberts