Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove empty create_and_test_config_common_properties tests #31359

Merged

Conversation

amyeroberts
Copy link
Collaborator

What does this PR do?

There's a bunch of tests which have create_and_test_config_common_properties implemented, but it's just an empty check. These should be removed as they falsely indicate config properties are being run in test_config, they clutter the code and this prevents them being copied again for new model implementations

@amyeroberts amyeroberts requested a review from ydshieh June 10, 2024 18:16
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I am not sure why this happens 😰 .

The canonical way looks like

    def setUp(self):
        self.model_tester = xxxModelTester(self)
        self.config_tester = ConfigTester(self, config_class=xxxConfig)

    def test_config(self):
        self.config_tester.run_common_tests()

I agree what is done in this PR. The above question could be left in a separate PR (when we have time)

@ydshieh
Copy link
Collaborator

ydshieh commented Jun 14, 2024

Thank you!

@amyeroberts amyeroberts merged commit 2081223 into huggingface:main Jun 14, 2024
23 checks passed
@amyeroberts amyeroberts deleted the remove-empty-config-checks branch June 14, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants