Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update text-to-speech.md #31269

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Update text-to-speech.md #31269

merged 1 commit into from
Jun 6, 2024

Conversation

jaguaryang
Copy link
Contributor

SpeechBrain usage has changed

SpeechBrain usage has changed
@amyeroberts
Copy link
Collaborator

cc @ylacombe

Copy link
Contributor

@ylacombe ylacombe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jaguaryang, thanks for the fix!

According to SpeechBrain docs, this is indeed the new way to import the EncoderClassifier!

The rest of the code should still work, notably the save_dir and the run_opt arguments passed to the EncoderClassifier.

This looks great to me @jaguaryang ! but could you run the snippet just to make sure it's working as expected?

@jaguaryang
Copy link
Contributor Author

Hi @ylacombe, sure, I have of course tested it successfully before I commit and create pull request. This doc worked now.

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating!

@amyeroberts amyeroberts merged commit a3d351c into huggingface:main Jun 6, 2024
20 checks passed
zucchini-nlp pushed a commit to zucchini-nlp/transformers that referenced this pull request Jun 11, 2024
zucchini-nlp pushed a commit to zucchini-nlp/transformers that referenced this pull request Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants