Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip failing JetMOE generation tests #31266

Merged

Conversation

amyeroberts
Copy link
Collaborator

@amyeroberts amyeroberts commented Jun 5, 2024

What does this PR do?

Two JetMOE generation tests started failing after the merge of #30536 - skipping them for now to make main happy again and avoid blocking PRs.

FAILED tests/models/jetmoe/test_modeling_jetmoe.py::JetMoeModelTest::test_beam_sample_generate - RuntimeError: cannot reshape tensor of 0 elements into shape [4, 0, 2, -1] because the unspecified dimension size -1 can be any value and is ambiguous
FAILED tests/models/jetmoe/test_modeling_jetmoe.py::JetMoeModelTest::test_generate_from_inputs_embeds_decoder_only - AssertionError: AssertionError not raised

Example run: https://app.circleci.com/pipelines/github/huggingface/transformers/94919/workflows/7b36e120-b4ce-45d4-ba80-15a681557e87/jobs/1247043

cc @ArthurZucker

@amyeroberts amyeroberts requested a review from ydshieh June 5, 2024 17:55
Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@amyeroberts
Copy link
Collaborator Author

Merging as flax equivalence tests for BigBird is unrelated

@amyeroberts amyeroberts merged commit 940fde8 into huggingface:main Jun 5, 2024
21 of 23 checks passed
@amyeroberts amyeroberts deleted the skip-failing-jetmoe-generate-tests branch June 5, 2024 18:06
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@ArthurZucker
Copy link
Collaborator

ArthurZucker commented Jun 6, 2024

Thanks, FYI @gante and @zucchini-nlp . Pinging @Cyrilvallez in case he has time to work on a fix 😉 We should have checked if Jamba tests also pass since the arch is also a bit new / hybrid!

@Cyrilvallez
Copy link
Member

Hi! Sorry about that, looking into it right now! Thanks @amyeroberts for noticing!

@Cyrilvallez Cyrilvallez mentioned this pull request Jun 6, 2024
zucchini-nlp pushed a commit to zucchini-nlp/transformers that referenced this pull request Jun 11, 2024
zucchini-nlp pushed a commit to zucchini-nlp/transformers that referenced this pull request Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants