Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blip: Deprecate BlipModel #31235

Merged
merged 2 commits into from
Jun 4, 2024
Merged

Blip: Deprecate BlipModel #31235

merged 2 commits into from
Jun 4, 2024

Conversation

younesbelkada
Copy link
Contributor

What does this PR do?

Fixes: #31199

As pointed out in #28034 and #25024 , specifically here: #28034 (comment) BlipModel is a copy-pasta from CLIPModel and cannot be used as it is using blip weights on the Hub. We should deprecate this class as it bring a lot of confusion to users and progressively remove it from the docs, then remove the BlipModel class itself in the future.

cc @amyeroberts

@younesbelkada younesbelkada requested a review from amyeroberts June 4, 2024 14:26
Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM! Could you add a deprecation message on the model page blip.md too?

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@younesbelkada younesbelkada merged commit 485d913 into main Jun 4, 2024
21 checks passed
@younesbelkada younesbelkada deleted the deprecate-blip branch June 4, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants