Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pytest -rsfE #31140

Merged
merged 1 commit into from
May 31, 2024
Merged

pytest -rsfE #31140

merged 1 commit into from
May 31, 2024

Conversation

ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented May 30, 2024

What does this PR do?

In #30318, @ArthurZucker and me decided to use -rs to show the skipped tests. However, this won't show the failed tests in the summary, neither the error out tests.

This PR uses -rsfE to show all tests except the passing one.

Without this PR

SKIPPED [1] tests/test_tokenization_common.py:1583: start to fail after # 29473. See https://github.com/huggingface/transformers/pull/29473#pullrequestreview-1945687810
SKIPPED [1] tests/test_tokenization_common.py:1971: No padding token.
SKIPPED [1] tests/test_tokenization_common.py:2005: No padding token.

With this PR

SKIPPED [1] tests/test_tokenization_common.py:1583: start to fail after # 29473. See https://github.com/huggingface/transformers/pull/29473#pullrequestreview-1945687810
SKIPPED [1] tests/test_tokenization_common.py:1971: No padding token.
SKIPPED [1] tests/test_tokenization_common.py:2005: No padding token.
FAILED tests/models/codegen/test_tokenization_codegen.py::CodeGenTokenizationTest::test_split_special_tokens - AssertionError: False is not true
FAILED tests/models/codegen/test_tokenization_codegen.py::CodeGenTokenizationTest::test_truncation - AssertionError: '\nif len_a > len_b:\n      result = a\nelse:\n      result = b' != '\nif len_a > len_b:      result = a\nelse:      result = b'

@ydshieh ydshieh requested a review from ArthurZucker May 30, 2024 12:33
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ydshieh ydshieh merged commit d19566e into main May 31, 2024
8 checks passed
@ydshieh ydshieh deleted the pytest_rsfE branch May 31, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants