Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup docker build #31119

Merged
merged 2 commits into from
May 29, 2024
Merged

Cleanup docker build #31119

merged 2 commits into from
May 29, 2024

Conversation

ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented May 29, 2024

What does this PR do?

I am staring to go back to other CI workflow (nightly, past, amd) and the first thing is to use runs-on: [intel-cpu, 8-cpu, ci] instead of runs-on: ubuntu-22.04 so we won't have disk space issue.

For .github/workflows/build-ci-docker-images.yml, we still keep runs-on: ubuntu-22.04 as we want to make sure the images there are really small (for CircleCI workflow/jobs)

sudo rm -rf /usr/local/lib/android
sudo rm -rf /usr/share/dotnet
sudo du -sh /usr/local/lib/
sudo du -sh /usr/share/
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't this any more as [intel-cpu, 8-cpu, ci] should be large enough.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it hurt to keep?

Copy link
Collaborator Author

@ydshieh ydshieh May 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not really. But I prefer not to have it as it would implicitly suggest we need it even if we are on [intel-cpu, 8-cpu, ci]. And if we don't have it in all places, it looks inconsistent and will be confusing IMO.

(and if we have it in all places, it's a bit too much ...)

@ydshieh ydshieh requested a review from amyeroberts May 29, 2024 14:59
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

With regards to the issues we were having last week with the images, are we 100% sure these work?

sudo rm -rf /usr/local/lib/android
sudo rm -rf /usr/share/dotnet
sudo du -sh /usr/local/lib/
sudo du -sh /usr/share/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it hurt to keep?

@ydshieh
Copy link
Collaborator Author

ydshieh commented May 29, 2024

With regards to the issues we were having last week with the images, are we 100% sure these work?

IIRC, that was for CircleCI images. For that part, my comment

For .github/workflows/build-ci-docker-images.yml, we still keep runs-on: ubuntu-22.04 as we want to make sure the images there are really small (for CircleCI workflow/jobs)

And in this PR, it's only about the images for GitHub Actions.

@ydshieh ydshieh merged commit 2b9e252 into main May 29, 2024
8 checks passed
@ydshieh ydshieh deleted the cleanup-docker-build branch May 29, 2024 17:43
@ydshieh ydshieh mentioned this pull request May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants