-
Notifications
You must be signed in to change notification settings - Fork 27.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[doc] Add references to the fine-tuning blog and distil-whisper to Whisper. #30938
[doc] Add references to the fine-tuning blog and distil-whisper to Whisper. #30938
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks @Vaibhavs10! Looks like there are some style tests failing. Could you rebase onto main to try and eradicate these?
7eae178
to
a414e39
Compare
Quality checks are failing on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding these resources!
4f5d312
to
678c55a
Compare
I think I messed up the merge! Whilst rebasing I synced my fork with transformers followed by
Where did I go wrong lol? |
@Vaibhavs10 A few questions to try and figure out what happened:
A few things might have happened. I suspect the culprit for any unexpected behaviour here is the pull, as it might have introduced merge commits. Working on my feature branch, these are the steps I normally take:
You don't technically need to update your main branch, you just need to fetch the most recent commits from upstream. The git history looks like what happens if one pulls then force pushes. The good new is, this can be rectified by rebase on main (no pulls!) and force pushing again. |
678c55a
to
a414e39
Compare
a414e39
to
c3e7b50
Compare
Thanks @amyeroberts - I synced via I followed your advice and that seems to have fixed the conflicts. Wow! git is hard - thank you for being so patient and explaining this to me. You both are the best! 🤗 Note: the code quality checks now pass haha! |
@Vaibhavs10 Do you have permission to merge? If not, I can do it for you |
Nope nope - would be great if you can merge. 🤗 Thanks again! |
…isper. (#30938) [doc] Add references to the fine-tuning blog and distil-whisper to Whisper doc.
…isper. (#30938) [doc] Add references to the fine-tuning blog and distil-whisper to Whisper doc.
…isper. (huggingface#30938) [doc] Add references to the fine-tuning blog and distil-whisper to Whisper doc.
[doc] Add references to the fine-tuning blog and distil-whisper to Whisper.
What does this PR do?
Before submitting
Pull Request section?
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
cc: @sanchit-gandhi