Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VideoLlava imports #30867

Merged
merged 2 commits into from
May 16, 2024
Merged

Conversation

amyeroberts
Copy link
Collaborator

@amyeroberts amyeroberts commented May 16, 2024

What does this PR do?

Currently, it's not possible to run from transformers import * when Pillow is not installed in the environment.

This is because in the model init, the image processor import is protected by is_vision_available, but the same pattern isn't reflected in the module init.

@amyeroberts amyeroberts requested a review from zucchini-nlp May 16, 2024 15:51
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@zucchini-nlp zucchini-nlp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for fixing!

Noted for future PRs where to add image processors in the main init :)

@amyeroberts amyeroberts merged commit 15c74a2 into huggingface:main May 16, 2024
21 checks passed
@amyeroberts amyeroberts deleted the fix-video-llava-import branch May 16, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants